fix: add "ts_ms" in source #12703
Merged
fix: add "ts_ms" in source #12703
+53
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
approved these changes
Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #12703 +/- ##
==========================================
- Coverage 69.46% 69.37% -0.09%
==========================================
Files 1471 1471
Lines 242032 242045 +13
==========================================
- Hits 168130 167926 -204
- Misses 73902 74119 +217
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #12599
according to https://debezium.io/documentation/reference/2.4/connectors/postgresql.html#postgresql-create-events
payload -> sourcepart also requirests_msbut it is missing in prev impl, causing the downstream panic.we are not adding other fields since sink in risingwave is not a snapshot and there is no related info.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.